Allow setting of "retrieveParametersFromServer" #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some SAML servers require this type of decoding, otherwise the SLO request fails. Ideally the library would perform both verifications (SAML-Toolkits/php-saml#466), but it seems upstream doesn't want to perform this change. Until we have considered a better solution for this, this adds a new checkbox that one can configure. Ref #403 Signed-off-by: Lukas Reschke <[email protected]>
|
@Quebrantos, if you still require this change a quick test by you would be awesome! :) |
Signed-off-by: Lukas Reschke <[email protected]>
blizzz
reviewed
May 5, 2021
Signed-off-by: Lukas Reschke <[email protected]>
blizzz
approved these changes
May 5, 2021
|
backports? |
|
/backport to stable-3.3 |
|
The backport to stable-3.3 failed. Please do this backport manually. |
|
😢 |
|
Backport to 3.3 at #526 |
blizzz
added a commit
that referenced
this pull request
May 6, 2021
[stable-3.3] slo web server decode (Backport #525)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some SAML servers require this type of decoding, otherwise the SLO request fails. Ideally the library would perform both verifications (SAML-Toolkits/php-saml#466), but it seems upstream doesn't want to perform this change.
Until we have considered a better solution for this, this adds a new checkbox that one can configure.
Ref #403
Signed-off-by: Lukas Reschke [email protected]