Fix opening federated shares #50292
Draft
Fix opening federated shares #50292
+18
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
provokateurin
force-pushed
the
fix/federated-share-opening
branch
from
24a89e5 to
e485f58
Compare
susnux
reviewed
Jan 21, 2025
| @@ -296,7 +296,8 @@ export default defineComponent({ | |||
|
|
|||
| // Check if the content is smaller than the viewport, meaning no scrollbar | |||
| const targetRow = Math.ceil(this.dataSources.length / this.columnCount) | |||
| if (targetRow < this.rowCount) { | |||
| // The offset is needed to avoid some items not being visible but also not being scrolled to. | |||
| if (targetRow < this.rowCount - 8) { | |||
There was a problem hiding this comment.
Sure it is not this? (8 is such a magic number)
Suggested change
| if (targetRow < this.rowCount - 8) { | |
| if (targetRow < (this.rowCount - ((this.bufferItems / this.columnCount) * 2)) { |
There was a problem hiding this comment.
Yeah I hate this magic number. I just checked which value fits and 8 is the one. I'm not sure on what it is based, but I can try your calculation.
There was a problem hiding this comment.
So it's 6 in list mode, but that doesn't work if the item is just one off screen. 8 is the minimum value that works here.
Merged
|
I noticed the viewer still fails to open when you do the process multiple times in a row. The first time works with this PR, but the subsequent attempts still fail. |
provokateurin
added
2. developing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Opening a federated share is currently broken, as the scroll does not work for items that are in a certain area outside the viewport and the viewer is not triggered because the permissions are wrong.
I tested this on stable30 and stable29 as well and those have the same bug and the fixes also work there.
Checklist