Add Tests for files UserConfig service #50050
Conversation
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Not ok: in_array("foo", [true, false]); // returns true
ok: in_array("foo", [true, false], true); // returns false
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
bromiesTM
force-pushed
the
kh/dev/files-userconfig-tests
branch
from
cf27019 to
49d10ed
Compare
| /** | ||
| * @var string | ||
| */ | ||
| private $userUID; | ||
|
|
||
| private $userMock; | ||
|
|
||
| /** @var IConfig|\PHPUnit\Framework\MockObject\MockObject */ | ||
| private $configMock; | ||
|
|
||
| /** @var IUserSession|\PHPUnit\Framework\MockObject\MockObject */ | ||
| private $userSessionMock; | ||
|
|
||
| /** | ||
| * @var UserConfig|\PHPUnit\Framework\MockObject\MockObject | ||
| */ | ||
| private $userConfigService; |
There was a problem hiding this comment.
| /** | |
| * @var string | |
| */ | |
| private $userUID; | |
| private $userMock; | |
| /** @var IConfig|\PHPUnit\Framework\MockObject\MockObject */ | |
| private $configMock; | |
| /** @var IUserSession|\PHPUnit\Framework\MockObject\MockObject */ | |
| private $userSessionMock; | |
| /** | |
| * @var UserConfig|\PHPUnit\Framework\MockObject\MockObject | |
| */ | |
| private $userConfigService; | |
| private string $userUID; | |
| private IUser&MockObject $userMock; | |
| private IConfig&MockObject $configMock; | |
| private IUserSession&MockObject $userSessionMock; | |
| private UserConfig $userConfig; |
| ->withAnyParameters() | ||
| ->willReturn($this->userMock); | ||
|
|
||
| $this->userConfigService = $this->getUserConfigService(['addActivity']); |
There was a problem hiding this comment.
| $this->userConfigService = $this->getUserConfigService(['addActivity']); | |
| $this->userConfig = new UserConfig($this->configMock, $this->userSessionMock); |
| $this->userUID = static::getUniqueID('user_id-'); | ||
| \OC::$server->getUserManager()->createUser($this->userUID, 'test'); | ||
| \OC_User::setUserId($this->userUID); | ||
| \OC_Util::setupFS($this->userUID); | ||
| $this->userMock = $this->getUserMock($this->userUID); |
There was a problem hiding this comment.
Is all this needed? 🤔
Looks ugly and calls obsolete methods.
| $userConfig = new UserConfig($this->configMock, $this->userSessionMock); | ||
| $userConfig->setConfig('crop_image_previews', true); |
There was a problem hiding this comment.
| $userConfig = new UserConfig($this->configMock, $this->userSessionMock); | |
| $userConfig->setConfig('crop_image_previews', true); | |
| $this->userConfig->setConfig('crop_image_previews', true); |
There was a problem hiding this comment.
And same for the other ones
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
TODO
Checklist
Screenshots before/after for front-end changes