fix: improve wording of occ:upgrade command when no upgrade is required #49914
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
requested review from
a team,
provokateurin,
sorbaugh and
come-nc
and removed request for
a team
provokateurin
approved these changes
Dec 18, 2024
come-nc
approved these changes
Dec 19, 2024
joshtrichards
approved these changes
Dec 21, 2024
| $output->writeln('<info>Nextcloud is already latest version</info>'); | ||
| $output->writeln('<info>No upgrade required.</info>'); | ||
| $output->writeln(""); | ||
| $output->writeln('Note that this command only performs the upgrade to the new version after the new sources have been installed'); |
There was a problem hiding this comment.
Suggested change
| $output->writeln('Note that this command only performs the upgrade to the new version after the new sources have been installed'); | |
| $output->writeln('Note: This command only upgrades to a new version if the installation files for a new release have already been deployed.'); |
|
Thanks for doing this. Coincidentally I was just looking at the counterpart of this in the built-in updater the other day: if I'll see about making a similar improvement over there. Addressing these seemingly little usability paper cuts improves the overall Nextcloud experience. Always a good thing. :-) |
joshtrichards
added
the
papercut
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current wording can be confusing as it implies that the instance is on the most up to date version. While it only means that the upgrade isn't required.