Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Update openapi-extractor to v1.3.0 #49905

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

provokateurin
Copy link
Member

Checklist

@provokateurin provokateurin added this to the Nextcloud 31 milestone Dec 17, 2024
@provokateurin provokateurin requested review from nickvergessen, come-nc, a team, Altahrim and artonge and removed request for a team December 17, 2024 19:59
Copy link
Member Author

@provokateurin provokateurin Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know these changes look very messed up, but it's correct and only because the routes, controllers and controller methods behind it are... Using index.php for OCSController and then returning JSONResponse 👩 🔫

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can that be fixed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only with a breaking change, so not really :(

@provokateurin provokateurin force-pushed the chore/deps/openapi-extractor branch from a22bf88 to c4f6cb5 Compare December 17, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants