Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: restore updated encrypted version when copying versions #49903

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: restore updated encrypted version when copying versions #49903

wants to merge 1 commit into from
+1 −0

Conversation

icewind1991
Copy link
Member

This was removed with #48651 but breaks encrypted versions.

@artonge do you remember why you removed it?

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Dec 17, 2024
@icewind1991 icewind1991 added this to the Nextcloud 31 milestone Dec 17, 2024
@icewind1991 icewind1991 requested review from artonge, a team, ArtificialOwl and yemkareems and removed request for a team December 17, 2024 18:56
come-nc
come-nc approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm this fixes versions compatibility with encryption.

It would be good to add an e2e test for this though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@artonge artonge Awaiting requested review from artonge

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems was automatically assigned from nextcloud/server-backend

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
2 participants
@icewind1991 @come-nc