feat: add pagination compatibility to cardav backend #47909
Draft
+20
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hamza Mahjoubi <[email protected]>
hamza221
added
enhancement
2. developing
hamza221
requested review from
ChristophWurst,
miaulalala and
tcitworld
as code owners
6 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| $objs = $this->carddavBackend->getCards($this->addressBookInfo['id']); | ||
| $offset = $_SERVER['HTTP_X_NEXTCLOUD_OFFSET']; | ||
| $limit = $_SERVER['HTTP_X_NEXTCLOUD_LIMIT']; | ||
| $objs = $this->carddavBackend->getCards($this->addressBookInfo['id'], $offset, $limit); |
Check failure
Code scanning / Psalm
InvalidArgument Error
| $objs = $this->carddavBackend->getCards($this->addressBookInfo['id']); | ||
| $offset = $_SERVER['HTTP_X_NEXTCLOUD_OFFSET']; | ||
| $limit = $_SERVER['HTTP_X_NEXTCLOUD_LIMIT']; | ||
| $objs = $this->carddavBackend->getCards($this->addressBookInfo['id'], $offset, $limit); |
Check failure
Code scanning / Psalm
InvalidArgument Error
|
I'd prefer a cursor based pagination if possible It's better for performance and more robust when the address book changes while the Contacts app is open |
| @@ -157,7 +157,9 @@ public function getChild($name) { | |||
| } | |||
|
|
|||
| public function getChildren() { | |||
| $objs = $this->carddavBackend->getCards($this->addressBookInfo['id']); | |||
| $offset = $_SERVER['HTTP_X_NEXTCLOUD_OFFSET']; | |||
| $limit = $_SERVER['HTTP_X_NEXTCLOUD_LIMIT']; | |||
There was a problem hiding this comment.
We should be able to use the standardized limit: https://datatracker.ietf.org/doc/html/rfc6352#section-8.6.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist