Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't flatten out albums #212

Merged
merged 1 commit into from
Feb 28, 2020
Merged

Don't flatten out albums #212

merged 1 commit into from
Feb 28, 2020

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Feb 28, 2020 •
edited by skjnldsv
Loading

Before:
before

After:
after

Fix #197

@rullzer
Don't flatten out albums
bcb0f07 
Signed-off-by: Roeland Jago Douma <[email protected]>
@rullzer rullzer added the 3. to review Waiting for reviews label Feb 28, 2020
@rullzer rullzer added this to the Nextcloud 19 milestone Feb 28, 2020
@skjnldsv
Copy link
Member

So it still display the full path if it find a picture in like any of the subfolder, right?

@rullzer
Copy link
Member Author

rullzer commented Feb 28, 2020

So it still display the full path if it find a picture in like any of the subfolder, right?

basically instead of only adding a folder that contains pictures. It now adds the top folder if it contains a subfolder with pictures.

@skjnldsv skjnldsv mentioned this pull request Feb 28, 2020
Closed
@skjnldsv skjnldsv linked an issue Feb 28, 2020 that may be closed by this pull request
Allow to browse the folder tree #142
Closed
@skjnldsv skjnldsv merged commit 30be4e6 into master Feb 28, 2020
@skjnldsv skjnldsv deleted the albums_tree_view branch February 28, 2020 09:12
@skjnldsv
Copy link
Member

/backport to stable18

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Feb 28, 2020
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Feb 28, 2020
Merged
@backportbot-nextcloud
Copy link

backport to stable18 in #213

@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request Pending backport by the backport-bot label Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@jospoortvliet jospoortvliet Awaiting requested review from jospoortvliet

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 19
Development

Successfully merging this pull request may close these issues.

No folder hierarchy in the "Your albums" tab is confusing Allow to browse the folder tree
2 participants
@rullzer @skjnldsv