Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sort lexicographical descendant for notes application #2487

Merged

Conversation

Kokika
Copy link
Contributor

@Kokika Kokika commented Nov 14, 2024

No description provided.

@tobiasKaminsky
Copy link
Member

Thank you very much for your contribution! 🎉

I tested it a bit and found that the "sorting header" is off:
2024-11-15-073927

Note "Sync" should be in "S", while the "New note…" should be in "N".
This works correct with ascending sort order.

@Kokika
Copy link
Contributor Author

Kokika commented Nov 16, 2024

Thank you for testing the PR. I fixed the SectionI Item position at ordering. Could you check the fix?

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@alperozturk96 alperozturk96 merged commit bbadb8e into nextcloud:main Nov 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants