Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto rename #3118

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Auto rename #3118

wants to merge 7 commits into from

Conversation

mpivchev
Copy link
Collaborator

@mpivchev mpivchev commented Oct 22, 2024 •
edited
Loading

NextcloudKit PR: nextcloud/NextcloudKit#99

Adds auto renaming functionality.

  • For sharing files and uploading files:

    • If it's a single file:

      1. Attempts to rename it automatically
      2. If not possible, show a rename prompt

    • If multiple files:

      1. Attempt to rename all files
      2. If any can't be renamed, cancel upload for them and show an error.
      3. The valid files are still uploaded

  • For dragging and dropping:

    1. Attempt to rename all files
    2. If any can't be renamed, cancel upload for them and show an error.
    3. The valid files are still uploaded

Examples:

ScreenRecording_10-22-2024.16-52-20_1.MP4
ScreenRecording_10-22-2024.16-52-44_1.MP4

@mpivchev mpivchev changed the base branch from master to develop October 22, 2024 08:52
@mpivchev
WIP
00ce6c9 
Signed-off-by: Milen Pivchev <[email protected]>
@mpivchev
Add files implementation
1e264df 
Signed-off-by: Milen Pivchev <[email protected]>
@mpivchev
WIP
51a653e 
Signed-off-by: Milen Pivchev <[email protected]>
@mpivchev
Finish drag and drop
ca746ac 
Signed-off-by: Milen Pivchev <[email protected]>
@mpivchev
Merge branch 'develop' of https://github.com/nextcloud/ios into auto-…
3e2bc5d 
…rename

Signed-off-by: Milen Pivchev <[email protected]>

# Conflicts:
#	Nextcloud.xcodeproj/project.pbxproj
@mpivchev mpivchev marked this pull request as ready for review October 22, 2024 14:50
@tobiasKaminsky tobiasKaminsky linked an issue Oct 23, 2024 that may be closed by this pull request
Windows compatible filenames: auto rename #3091
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marinofaggiana marinofaggiana Awaiting requested review from marinofaggiana

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows compatible filenames: auto rename
1 participant
@mpivchev