Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(go.php): Detect browser language to redirect to user manual in preferred language #12485

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

provokateurin
Copy link
Member

No description provided.

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't test but design-wise the approach is good.

@provokateurin provokateurin force-pushed the feat/go/language-detection branch from 45ab712 to 84c1a86 Compare January 13, 2025 10:01
@provokateurin provokateurin marked this pull request as ready for review January 13, 2025 10:01
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Small nitpick.

go.php Outdated Show resolved Hide resolved
go.php Outdated Show resolved Hide resolved
go.php Outdated Show resolved Hide resolved
@provokateurin provokateurin force-pushed the feat/go/language-detection branch from 84c1a86 to 1321b4e Compare January 13, 2025 13:38
@provokateurin provokateurin requested a review from come-nc January 13, 2025 13:38
go.php Outdated Show resolved Hide resolved
@provokateurin provokateurin merged commit 30f926c into master Jan 14, 2025
12 checks passed
@provokateurin provokateurin deleted the feat/go/language-detection branch January 14, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants