Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to force end users to actively select a suitable local directory #7497

Draft
wants to merge 247 commits into
base: master
Choose a base branch
from

Conversation

rwalke
Copy link

@rwalke rwalke commented Nov 14, 2024

Feature description (see #7454)

When a user installs Nextcloud, the wizard uses a default directory that works.
Often, administrators do not recommend this folder as a local directory, e.g. in the Windows OS user's roaming profile.
The user should be required to actively select a local directory.

If the automatic software distribution could distribute an option like
proposeLocalDir=FALSE
to the nextcloud.cfg file,
the Nextcloud wizard would wait until the users themselves selected a suitable directory.

This would help administrators in organizations to promote a certain style of Nextcloud usage.
Nothing would change for individual Nextcloud users.

This is a first step to illustrate the idea.
The next step would be to read the nextcloud.cfg file and evaluate an additional option.

@rwalke rwalke force-pushed the feature/proposeLocalDir branch from 691fe9f to 7339ba9 Compare November 14, 2024 08:08
@camilasan
Copy link
Member

camilasan commented Nov 14, 2024

Thanks for trying to implement your feature request! ❤️

When a user installs Nextcloud, the wizard uses a default directory that works.
Often, administrators do not recommend this folder as a local directory, e.g. in the Windows OS user's roaming profile.
The user should be required to actively select a local directory.

I am not sure if I follow your proposal.
There is an install folder and there is a sync folder.
In both cases Qt uses default system paths, each platform has one.
Your PR is trying to change the sync folder setting dialog.

the Nextcloud wizard would wait until the users themselves selected a suitable directory.

I am not sure this is a good idea unless the user knows what they are doing.
For the sync folder and for the install folder the client already lets the user pick a location.
Your idea could easily be workaround by instructing the users to install in a different location.

@@ -5981,7 +5981,7 @@ Le serveur a répondu avec l&apos;erreur : %2</translation>
<message>
<location filename="../src/gui/wizard/welcomepage.cpp" line="70"/>
<source>Easy-to-use web mail, calendaring &amp; contacts</source>
<translation>Courrier électronique, calendrier et contacts en ligne faciles à utiliser</translation>
<translation>E-mail, agenda et contacts en ligne faciles à utiliser</translation>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation files should not be changed, we pull them from Transifex: https://app.transifex.com/nextcloud/nextcloud/client/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I plan to add a few more lines of code so that the general user gets the default folder as usual. Only in special cases do I want to force the user to manually select a folder without a default (or an institution-specific default).

@@ -119,6 +119,7 @@ void OwncloudSetupWizard::startWizard()
localFolder = QDir::homePath() + QLatin1Char('/') + localFolder;
}

localFolder = "Please select folder";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you can see in line 119, localFolder is meant to be a path to a local folder.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I plan to add a few more lines of code so that the general user gets the default folder as usual. Only in special cases do I want to force the user to manually select a folder without a default (or an institution-specific default).

@rwalke
Copy link
Author

rwalke commented Nov 15, 2024 via email

@rwalke
Copy link
Author

rwalke commented Nov 15, 2024 via email

rwalke and others added 23 commits December 4, 2024 15:50
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
add note on exclude file

nextcloud#2917

Signed-off-by: Rello <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
Co-authored-by: Camila Ayres <[email protected]>
Signed-off-by: Rello <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
Exit setupFavLink function when SHGetKnownFolderPath fails.

Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
nextcloud-bot and others added 24 commits December 4, 2024 15:50
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
We don't really need to have the check fo paletteSignalsConnected

Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
Theme may be instantiated before the qApp is available

Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
This way we avoid the computation that happens in Theme::darkMode each
time the property is accessed

Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
Signed-off-by: Matthieu Gallien <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
Signed-off-by: Matthieu Gallien <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
should ensure comparisons of locale aware text is compared against
locale aware test data

will remove portability issues especially on Windows

Signed-off-by: Matthieu Gallien <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
ensure we report the expected availability erro for non existing files

Signed-off-by: Matthieu Gallien <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
will prevent truncating the modification time when changing the lock
state of a file

could be visible when using an office software to open an office file
with automated locking happening after the file gets opened

Signed-off-by: Matthieu Gallien <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
Signed-off-by: Matthieu Gallien <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
tell tr that there is a number inside the translated string such that
translators can provide the proper plural forms

Changing text strings to correctly import them into Transifex.
Issue nextcloud#3776.

Signed-off-by: Valdnet <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
we give them to APIs expecting int

we compare them to int values

Signed-off-by: Matthieu Gallien <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Rainer Walke <[email protected]>
@rwalke rwalke force-pushed the feature/proposeLocalDir branch from 6b24b06 to 568e782 Compare December 4, 2024 14:51
@Rello Rello added this to the 3.16.0 milestone Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants