-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
detect the terms of service app is requiring the user to sign them #7385
Conversation
/backport to stable-3.13 |
/backport to stable-3.12 |
/backport to stable-3.14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just very minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Camila's suggestions, otherwise LGTM
7537976
to
f260ef3
Compare
will query the sign state for the terms of service and automatically pause or resume sync Signed-off-by: Matthieu Gallien <[email protected]>
will trigger a check of the server connectivity in case of content access denied reporting when listing folders during discovery should allow discovering early that terms of service need to be signed Signed-off-by: Matthieu Gallien <[email protected]>
99927f1
to
968289c
Compare
AppImage file: nextcloud-PR-7385-968289cbf0c287a4f58d751ff098e7b658e644da-x86_64.AppImage |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
will query the sign state for the terms of service and automatically pause or resume sync