Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a context menu for the sharees search field #7355

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

claucambra
Copy link
Collaborator

Closes #6199

Screenshot 2024-10-18 at 12 03 26

@claucambra claucambra added this to the 3.15.0 milestone Oct 18, 2024
@claucambra claucambra self-assigned this Oct 18, 2024
@mgallien mgallien force-pushed the bugfix/context-menu-sharees branch from f7968f5 to 3f34805 Compare November 18, 2024 08:40
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7355-3f34805183fcbe63241ae9cff3ba905a11c0187b-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does not work so nicely if your platform Qt qml style is also providing a context menu
in such a case, you get a sequence of 2 different context menus which makes it broken from user perspective

@claucambra
Copy link
Collaborator Author

@mgallien argh, I had not thought of that, thanks for bringing it up

are you aware of how we can detect this? I would rather not traverse the scene graph to check...

@claucambra claucambra modified the milestones: 3.15.0, 3.16.0 Nov 20, 2024
@claucambra claucambra modified the milestones: 3.16.0, 3.16.1 Feb 5, 2025
@mgallien mgallien modified the milestones: 3.16.1, 3.17.0 Mar 12, 2025
@mgallien
Copy link
Collaborator

@mgallien argh, I had not thought of that, thanks for bringing it up

are you aware of how we can detect this? I would rather not traverse the scene graph to check...

should we not check what is the QML style in use and enable or disable some of our added features ?

@claucambra claucambra force-pushed the bugfix/context-menu-sharees branch from 3f34805 to 4411add Compare March 14, 2025 06:39
@claucambra claucambra requested a review from nilsding as a code owner March 14, 2025 06:39
@claucambra claucambra force-pushed the bugfix/context-menu-sharees branch from 4411add to b9566e5 Compare March 14, 2025 06:41
@claucambra
Copy link
Collaborator Author

@mgallien argh, I had not thought of that, thanks for bringing it up
are you aware of how we can detect this? I would rather not traverse the scene graph to check...

should we not check what is the QML style in use and enable or disable some of our added features ?

Okay, have implemented this

@claucambra claucambra requested a review from mgallien March 14, 2025 06:43
…yle already provides a menu

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra claucambra force-pushed the bugfix/context-menu-sharees branch from b9566e5 to 426a0a8 Compare March 14, 2025 06:43
Copy link
Member

@nilsding nilsding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for some reason the suggestions popup also shows up along with the context menu when right-clicking on Win11 (after fixing the compilation as described below)

Screencast_20250314_090640.webm

@claucambra
Copy link
Collaborator Author

for some reason the suggestions popup also shows up along with the context menu when right-clicking on Win11 (after fixing the compilation as described below)

Screencast_20250314_090640.webm

I've added a call on aboutToShow that explicitly hides the suggestions popup if it's visible; does this fix the issue on Windows?

Copy link

Artifact containing the AppImage: nextcloud-appimage-pr-7355.zip

SHA256 checksum: d582e1e9d968e30ba3d4073ab07c202b301cd4b51b3e177f15b0bf764661ad3a

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@nilsding
Copy link
Member

nilsding commented Mar 14, 2025

I've added a call on aboutToShow that explicitly hides the suggestions popup if it's visible; does this fix the issue on Windows?

It's a bit better now with the z-index set, but it still appears when the TextField is focused sometimes:

Screencast_20250314_094457.webm

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)
13 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Context menu for share window
4 participants