-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a context menu for the sharees search field #7355
base: master
Are you sure you want to change the base?
Conversation
f7968f5
to
3f34805
Compare
AppImage file: nextcloud-PR-7355-3f34805183fcbe63241ae9cff3ba905a11c0187b-x86_64.AppImage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does not work so nicely if your platform Qt qml style is also providing a context menu
in such a case, you get a sequence of 2 different context menus which makes it broken from user perspective
@mgallien argh, I had not thought of that, thanks for bringing it up are you aware of how we can detect this? I would rather not traverse the scene graph to check... |
|
should we not check what is the QML style in use and enable or disable some of our added features ? |
Signed-off-by: Claudio Cambra <[email protected]>
… field context menu Signed-off-by: Claudio Cambra <[email protected]>
…s for QtQuick text fields Signed-off-by: Claudio Cambra <[email protected]>
3f34805
to
4411add
Compare
4411add
to
b9566e5
Compare
Okay, have implemented this |
…yle already provides a menu Signed-off-by: Claudio Cambra <[email protected]>
b9566e5
to
426a0a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for some reason the suggestions popup also shows up along with the context menu when right-clicking on Win11 (after fixing the compilation as described below)
Screencast_20250314_090640.webm
Fixes building on Windows Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
I've added a call on aboutToShow that explicitly hides the suggestions popup if it's visible; does this fix the issue on Windows? |
Artifact containing the AppImage: nextcloud-appimage-pr-7355.zip SHA256 checksum: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
It's a bit better now with the z-index set, but it still appears when the TextField is focused sometimes: Screencast_20250314_094457.webm |
|
Closes #6199