Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Update channel UI enhancements #6873

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

WIP: Update channel UI enhancements #6873

wants to merge 12 commits into from
+191 −172

Conversation

camilasan
Copy link
Member

@camilasan camilasan commented Jul 2, 2024 •
edited
Loading

TODO:

  • on the settings page, the channels could be in radio buttons instead of in a dropdown.
    • vertical arrangement instead of horizontal
  • that way we could move the channel info directly onto the settings page
  • change the confirmation dialog to show only the "downgrading is not possible" message
  • show the confirmation dialog only when changing from daily to beta or beta to stable
  • hide the update channel UI for branded clients (stable is the default)
  • Why are we storing serverHasValidSubscription and desktopEnterpriseChannel as a setting? Shouldn't we just fetch this from capabilities on startup?

Before:
before

After:
after

See #6658

camilasan added 12 commits June 26, 2024 18:47
@camilasan
Add daily update channel.
e07f6f5 
- Set update channel options list in slotUpdateInfo.

Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Modernize ConfigFile::updateChannel and Updater::getQueryParams.
d5ecfa6 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Adds info about daily builds to message shown if user changes update …
e396fbe 
…channel.

- Also makes the explanation more concise.

Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Clean up code in GeneralSettings.
1dfa608 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
List daily update channel in the general settings view.
d905401 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Change the default MIRALL_VERSION_SUFFIX from "git" to "daily".
6f60094 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Use the value from MIRALL_VERSION_SUFFIX as the default update channel.
1e68dab 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Add versionSuffix function to Theme.
8d22b61 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Enforce the update channel based on the current client installed.
13b0d9e 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Improve text displayed when user switches update channel.
a9ed8f9 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Use radio buttons instead of a combo box to list the update channels.
e788c2f 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Remove commented out line.
091b49a 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan camilasan mentioned this pull request Jul 2, 2024
Merged
4 tasks
@camilasan camilasan changed the title Enh/update channel Update channeln UI enhancements Jul 2, 2024
@camilasan camilasan changed the title Update channeln UI enhancements Update channel UI enhancements Jul 2, 2024
@camilasan camilasan mentioned this pull request Jul 4, 2024
Merged
@tobiasKaminsky
Copy link
Member

/backport to stable-3.14

@camilasan camilasan changed the title Update channel UI enhancements WIP: Update channel UI enhancements Nov 28, 2024
@camilasan camilasan self-assigned this Dec 19, 2024
@camilasan camilasan added this to the 3.16.0 milestone Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@camilasan camilasan

Labels
backport-request
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@camilasan @tobiasKaminsky @splitt3r