Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify constructor property declarations #4284

Merged

Conversation

AIlkiv
Copy link
Contributor

@AIlkiv AIlkiv commented Jan 3, 2025

No description provided.

@hamza221 hamza221 force-pushed the refactor/constructor-properties branch from 5588f95 to 172ca5e Compare January 3, 2025 11:27
@hamza221
Copy link
Contributor

hamza221 commented Jan 3, 2025

please run composer cs:fix locally then amend the changes and change the commit message to be conventional

@AIlkiv AIlkiv force-pushed the refactor/constructor-properties branch from 172ca5e to 0c0bf64 Compare January 3, 2025 14:19
@AIlkiv AIlkiv changed the title Refactored constructor property declarations to use shorter syntax refactor: simplify constructor property declarations Jan 3, 2025
@AIlkiv AIlkiv requested a review from hamza221 January 3, 2025 14:20
@SebastianKrupinski SebastianKrupinski merged commit aaea981 into nextcloud:main Jan 6, 2025
33 checks passed
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants