Move users_picker profile custom picker to contacts

[julien-nc]

This replaces #3487. I can't push in the branch there.

@ChristophWurst

• It's rebased on main
• Adjusted the vite config
• The bio processing is now using multi-byte proof functions
• Nitpick addressed: The condition in the reference provider was inverted
• Now checks if the profile is enabled (when resolving a link)
• Fixed widget style issues
• Fixed the tests
• Fixed the licenses

About #3487 (review) I'm not sure I see the issue. The frontend is using the ocs/v2.php/core/autocomplete/get endpoint which should respect the sharing settings.

The reference provider now checks if the profile is enabled or not with the IAccountManager::PROPERTY_PROFILE_ENABLED account property.
It seems fine to resolve any /u/USER_ID link as long as the profile is enabled.

[SebastianKrupinski]

Hi @julien-nc

How do I test? What am I looking for.

[julien-nc]

@SebastianKrupinski This adds a "profile picker" entry in the smart picker and a reference widget (link preview) for /u/USER_ID links.

[codecov]

Codecov Report

Attention: Patch coverage is 39.03743% with 114 lines in your changes missing coverage. Please review.

Project coverage is 12.48%. Comparing base (430505e) to head (a7cc035).
Report is 27 commits behind head on main.

Files with missing lines	Patch %	Lines
.../components/ProfilePicker/ProfilesCustomPicker.vue	0.00%	60 Missing ⚠️
...nts/ProfilePicker/ProfilePickerReferenceWidget.vue	0.00%	24 Missing ⚠️
src/reference.js	0.00%	17 Missing ⚠️
lib/Reference/ProfilePickerReferenceProvider.php	91.25%	7 Missing ⚠️
lib/Listener/ProfilePickerReferenceListener.php	0.00%	4 Missing ⚠️
lib/AppInfo/Application.php	0.00%	2 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##               main    #4231       +/-   ##
=============================================
- Coverage     66.33%   12.48%   -53.85%     
- Complexity      263      290       +27     
=============================================
  Files            25      122       +97     
  Lines           799     5647     +4848     
  Branches          0     1216     +1216     
=============================================
+ Hits            530      705      +175     
- Misses          269     4821     +4552     
- Partials          0      121      +121     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[julien-nc]

@SebastianKrupinski I made a few more adjustments. CI is green. It is now ready to be tested.

[ChristophWurst]

Dear @julien-nc,

Thank you for your contribution!

About #3487 (review) I'm not sure I see the issue. The frontend is using the ocs/v2.php/core/autocomplete/get endpoint which should respect the sharing settings.

That is correct for the part of searching. But once a reference is selected, there is no more check in ProfilePickerReferenceProvider.
I could abuse that to render a reference to a user I would otherwise not see. The reference contains any non-private data.

I suggest we test this specific scenario and see how the code behaves. I just want to have clarity on this point before the code goes into the main branch.

[ChristophWurst]

@julien-nc on a higher level, what do you think about moving the app/code into server instead? The picker picks users, not contacts. There is nothing specific to contacts (or event teams) in the code.

[julien-nc]

@ChristophWurst Yes we can move it to server.

I'd still like to have your opinion on the last changes. We now check the visibility of the profile fields with the ProfileManager. This respects the scopes and the visibility settings.

I could abuse that to render a reference to a user I would otherwise not see. The reference contains any non-private data.

Now the preview can't display any information that would not be visible by clicking the link to browse the profile page.