Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Nextcloud 25 support #3777

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Drop Nextcloud 25 support #3777

merged 1 commit into from
Jan 9, 2024

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Jan 8, 2024

Fixes #3776

Signed-off-by: hamza mahjoubi <[email protected]>
@hamza221 hamza221 added enhancement New feature or request 3. to review Waiting for reviews labels Jan 8, 2024
@hamza221 hamza221 self-assigned this Jan 8, 2024
@hamza221
Copy link
Contributor Author

hamza221 commented Jan 8, 2024

/backport to stable5.5

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (08d6871) 2.51% compared to head (7839145) 2.51%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3777   +/-   ##
=====================================
  Coverage   2.51%   2.51%           
=====================================
  Files         89      89           
  Lines       4411    4411           
  Branches    1126    1126           
=====================================
  Hits         111     111           
  Misses      4180    4180           
  Partials     120     120           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If 26 is PHP8.0+, PHP7.4 can go next :)

@ChristophWurst
Copy link
Member

The 25 jobs have to be removed from the protection of main manually at https://github.com/nextcloud/contacts/settings/branches. Make sure to add any new jobs added through the adjusted matrix. Required jobs ensure that Github doesn't merge PRs before all checks have passed.

In the future we can also migrate this repo to use a summary workflow. This is a virtual job that can be referenced from branch protection and doesn't change when the matrix changes.

@hamza221 hamza221 merged commit 8f30427 into main Jan 9, 2024
24 checks passed
@hamza221 hamza221 deleted the drop-25-support branch January 9, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Nextcloud 25 support
2 participants