Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add pagination #919

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add pagination #919

wants to merge 1 commit into from

Conversation

hamza221
Copy link

@hamza221
feat: add pagination
ce9b844 
Signed-off-by: Hamza Mahjoubi <[email protected]>
@hamza221 hamza221 added enhancement New feature or request feature: CardDAV Related to CardDAV 3. to review Waiting for reviews labels Sep 11, 2024
@hamza221 hamza221 self-assigned this Sep 11, 2024
@hamza221 hamza221 requested a review from st3iny as a code owner September 11, 2024 20:19
@hamza221 hamza221 mentioned this pull request Sep 11, 2024
Open
6 tasks
st3iny
st3iny requested changes Sep 12, 2024
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Let's wait until the server PR is finalized.

src/models/addressBook.js
Comment on lines +180 to +181
'X-NEXTCLOUD-Offset': offset,
'X-NEXTCLOUD-limit': queryLimit,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'X-NEXTCLOUD-Offset': offset,
'X-NEXTCLOUD-limit': queryLimit,
'X-Nextcloud-Offset': offset,
'X-Nextcloud-Limit': queryLimit,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st3iny st3iny st3iny requested changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Requested changes must be addressed to merge this pull request.

Assignees

@hamza221 hamza221

Labels
3. to review Waiting for reviews enhancement New feature or request feature: CardDAV Related to CardDAV
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamza221 @st3iny