purge point on external storage #151
Conversation
Signed-off-by: Maxence Lange <[email protected]>
|
I believe that purgeExternalRestoringPoints() has the same logic problems described in PR #183 . I'll try to implement/test this code when I have some time. |
|
I think it should be this straightforward but I'm kicking off some testing to see how this behaves over time |
|
I've applied this pull with my modifications and it's worked perfectly for the last few days. |
| continue; | ||
| } | ||
| $i++; | ||
| if ($i > $c) { |
There was a problem hiding this comment.
This logic leads to orphaned differential restoring points. (same as current internal logic)
Parents need to be kept until no depended restoring points are available.
There was a problem hiding this comment.
Please see my proposed replacement of this patch above. I eliminated the problem. I was hoping @ArtificialOwl would incorporate... didn't want to create a competing pull request.
There was a problem hiding this comment.
I have been thinking about this logic problem for a while now.
It should be handled in an easy way so that everybody can understand it.
Also it should be the same logic for internal and external storage as long as we have only the setting for number of items to be kept.
I'm already working on such a solution for internal storage first.
If it works as intended I would also suggest to incorporate the adaption into @ArtificialOwl pull request.
It would be a good idea to discuss our solutions to find a consensus.
There was a problem hiding this comment.
I have been using the code I provided in the two different pull requests for over two months and everything has worked perfectly aside from the isArchive() issue you mentioned. Please look at https://github.com/jxmx/backup/tree/fix/147/purge-external-storage and Pull #183. I'm fairly confident the logic is solid and has been working in my environment.
There was a problem hiding this comment.
I have seen your PR, I will review it later today.
|
Fixes #176 |
|
Please see Pull #219 which might help the review process. |
No description provided.