Skip to content

feat: enhance unified search #15580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: enhance unified search #15580

wants to merge 3 commits into from

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Sep 8, 2025 •
edited
Loading

  • Tests written, or not not needed

Issue: nextcloud/files-clients#87

@alperozturk96
feat: enhance unified search
398b9f3 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 alperozturk96 linked an issue Sep 8, 2025 that may be closed by this pull request
Enhance files search nextcloud/files-clients#87
Open
@alperozturk96 alperozturk96 mentioned this pull request Sep 8, 2025
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 8, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15580.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 8, 2025

Codacy

Lint

TypemasterPR
Warnings4747
Errors1111

SpotBugs

CategoryBaseNew
Bad practice5959
Correctness6868
Dodgy code276276
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3535
Performance4848
Security1818
Total514514

@alperozturk96
Copy link
Collaborator Author

alperozturk96 commented Sep 8, 2025 •
edited
Loading

Current state of this PR:

@tobiasKaminsky

Screen.Recording.2025-09-08.at.16.08.11.2.mp4

kra-mo
kra-mo approved these changes Sep 12, 2025
View reviewed changes
Copy link
Member

@kra-mo kra-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I understand, this looks good.

jancborchardt
jancborchardt approved these changes Sep 15, 2025
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alperozturk96 looks good generally, only some feedback – which could also be done in a follow-up though.

  • The folder icons for the current folder are a different color than that of others?
  • There is very little margin above the section headers, making it feel quite cramped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@kra-mo kra-mo kra-mo approved these changes

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees
No one assigned
Labels
2. developing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance files search
3 participants
@alperozturk96 @jancborchardt @kra-mo