fix: download progress listener #15544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alperozturk <[email protected]>
alperozturk96
force-pushed
the
fix/listen-unnecessary-worker-download-state
branch
from
59c813c to
37df0dc
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15544.apk |
tobiasKaminsky
approved these changes
Sep 12, 2025
alperozturk96
deleted the
fix/listen-unnecessary-worker-download-state
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Previously, download progress worker states were being observed in both
FileDisplayActivityandFileDetailsFragment. This caused unnecessary calls inFileDisplayActivity, even though progress tracking is only required inFileDetailsFragment.In addition, progress notifications for large file downloads were repeatedly triggering sounds, leading to an annoying “beeping” effect during long transfers.
Changes
Separated event handling so that download progress is only observed within
FileDetailsFragment, avoiding redundant updates inFileDisplayActivity.Updated the download notification configuration to suppress repeated alert sounds for progress updates.
Before
Screen.Recording.2025-09-05.at.12.54.38.mp4
After
after.mp4