Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check Nullable Fields During Folder Changes Check #13937

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Check Nullable Fields During Folder Changes Check #13937

wants to merge 2 commits into from

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Nov 4, 2024 •
edited
Loading

  • Tests written, or not not needed

How to Test?

  1. Place a debugger in the checkForChanges() function.
  2. Try syncing both a changed and an unchanged folder; the debugger should hit the selected line, and the correct result should be returned.

@alperozturk96 alperozturk96 linked an issue Nov 4, 2024 that may be closed by this pull request
NPE: Attempt to invoke virtual method 'java.lang.String com.owncloud.android.datamodel.OCFile.getEtag()' via checkForChanges #13784
Open
@alperozturk96
Copy link
Collaborator Author

@tobiasKaminsky Could you check the returned ResultCodes? Are they correct? Maybe some other result codes can suit better.

@alperozturk96 alperozturk96 changed the title BugFix - Check Nullable Fields During Folder Changes Check Check Nullable Fields During Folder Changes Check Nov 4, 2024
@alperozturk96 alperozturk96 force-pushed the bugfix/npe-checkForChanges branch 2 times, most recently from 72b5793 to 19a2b39 Compare November 6, 2024 07:55
@alperozturk96 alperozturk96 added this to the Nextcloud App 3.30.5 milestone Nov 11, 2024
@alperozturk96 alperozturk96 force-pushed the bugfix/npe-checkForChanges branch from 19a2b39 to a89dd03 Compare November 11, 2024 13:15
tobiasKaminsky
tobiasKaminsky requested changes Nov 11, 2024
View reviewed changes
Copy link
Member

@tobiasKaminsky tobiasKaminsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are too risky without real tests.

@tobiasKaminsky tobiasKaminsky removed this from the Nextcloud App 3.30.5 milestone Nov 11, 2024
@alperozturk96 alperozturk96 force-pushed the bugfix/npe-checkForChanges branch from c204eb2 to a015f70 Compare December 30, 2024 08:00
@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13937.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings5959
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5858
Dodgy code298298
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5353
Security1818
Total508508

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky requested changes

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
1. to develop
Projects
None yet
Milestone
No milestone
2 participants
@alperozturk96 @tobiasKaminsky