Drop of PHP 7.4 to comply with server master #93
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
changed the title
nickvergessen
changed the title
|
Too soon to add 8.2 in my opinion, the CI on server is not yet passing on 8.2: nextcloud/server#32463 |
|
(well you can add it on lint, lint already has 8.2 on server, but for phpunit it seems early) |
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
bugfix/noid/prepare-7.4-drop-from-master
branch
from
867f99b to
4726f06
Compare
|
Okay, removed the 8.2 for now from phpunit |
Signed-off-by: Joas Schilling <[email protected]>
come-nc
approved these changes
Nov 7, 2022
nickvergessen
changed the title
|
What about using |
skjnldsv
approved these changes
Dec 13, 2022
For CI it’s better to default to the oldest one, to catch any breaking by using too modern syntax or feature. |
|
Then please rebase and LGTM? :) |
|
I duplicated my own work... |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joas Schilling [email protected]