This repository has been archived by the owner on Nov 12, 2019. It is now read-only.
Allow daemons script to be executed from any dir #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use ssl for rubygems
- move towards a gem structure (easy install)
- module/class/file naming convention
- low resolution and lag challenges
- easy to add additional "collectors"
…on (eg. instance)
Nathan/iam roles
Ruby 1.8.7 bugfix
documented region config
The link to http://www.paulsamiq.com/how-to-use-amazons-iam-with-new-relics-aws-plugin/ now redirects to a random "advertising" page on http://www.chicagotribune.com/brandpublishing/. There is no longer relevant information at that URL.
Remove inaccurate link about AWS IAM
…-1, ap-northeast-2
support region eu-central-1, ap-northeast-2
…efresh Bump to 3.3.4, support ap-south-1
…0160902 Update the AMI link to current version
Modify regions config key to use proper YAML syntax in all places
Add Application Load Balancer collector
To match our processes.
Updated README to include Contributing paragraph
rantler
reviewed
Nov 21, 2016
bin/daemon
Outdated
| @@ -10,5 +10,6 @@ | |||
|
|
|||
| require 'daemons' | |||
|
|
|||
| pwd = File.join(File.dirname(File.expand_path(__FILE__)), "../") | |||
| Daemons.run('bin/newrelic_aws', :dir_mode => :normal, :dir => pwd) | |||
| pwd=File.dirname(File.expand_path(__FILE__)) | |||
There was a problem hiding this comment.
pwd has no use after L15. Consider in-lining the value there.
rantler
reviewed
Nov 21, 2016
bin/daemon
Outdated
| Daemons.run('bin/newrelic_aws', :dir_mode => :normal, :dir => pwd) | ||
| pwd=File.dirname(File.expand_path(__FILE__)) | ||
|
|
||
| Daemons.run(File.join(pwd,'newrelic_aws')) |
There was a problem hiding this comment.
Nit: The style in this file is (was) to use whitespace after commas.
|
@rantler - looking better? |
|
🍻! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Look for newrelic_aws in the directory relative to the daemons script's absolute path.
The below is now able to run successfully
Example Execution Pattern:
sudo BUNDLE_GEMFILE=<path_to_plugin>/newrelic_aws_cloudwatch_plugin-latest/Gemfile /usr/local/bin/bundle exec <path_to_plugin>/newrelic_aws_cloudwatch_plugin-latest/bin/daemon run