Remove outdated deprecation message about disabled_* config options #3005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaylareopelle
force-pushed
the
remove-outdated-deprecation-message
branch
from
a4055ab to
d3390a0
Compare
We removed all the disabled_* configuration options that correlate to an instrumentation.* configuration option in our last major version. The disabled_* options that remain will not be replaced with instrumentation.* options because they do not use alias method chaining or module prepending or are not related to instrumentation-related, but rather specific features. Also, add alias for disable_active_job.
kaylareopelle
force-pushed
the
remove-outdated-deprecation-message
branch
from
d3390a0 to
31cd3ec
Compare
kaylareopelle
changed the title
SimpleCov Report
|
kaylareopelle
requested review from
hannahramadan and
tannalynn
as code owners
tannalynn
previously approved these changes
Jan 2, 2025
Co-authored-by: Hannah Ramadan <[email protected]>
Co-authored-by: Hannah Ramadan <[email protected]>
tannalynn
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing logs for a GTSE, I noticed this outdated DEBUG-level log message:
There is no
instrumentation.action_dispatchconfig option, and one is not planned to be added in the future. Action Dispatch instrumentation usesActiveSupport::Notifications, a pub/sub model. Theinstrumentation.*config options are for instrumentation that uses module prepending or alias method chaining.We removed all the
disabled_*configuration options that correlate to aninstrumentation.*configuration option in our last major version. Thedisabled_*options that remain will not be replaced withinstrumentation.*options because they do not use alias method chaining or module prepending or are not related to instrumentation-related, but rather relate to specific features.Also, add an alias for the
disable_activejobinstrumentation to also accept,disable_active_job.