Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: scala for java tests, set fossaAnalyzeResult to N/A #64

Merged
4 commits merged into from
May 29, 2024

Conversation

elaguerta-nr
Copy link
Contributor

@elaguerta-nr elaguerta-nr commented May 22, 2024

Fixes

  • In fossa-scala.yml, correct the condition to check for newrelic-java-tests repo
  • If fossa-list-targets does not find targets, set fossaAnalyzeResult to "N/A"
    • currently fossaAnalyzeResult has the default value of "Error" for repos without targets. Changing to "N/A" makes the data more clear.
    • this change does not affect whether the workflow passes or fails

Refactors

  • In all workflows, move variables for custom properties from step outputs to a job environment variable in order to simplify sharing the values across workflow steps.
  • Add descriptor to workflow name, i.e. FOSSA CLI Analysis - Gradle
  • standardize grep for error logs to be grep -i error (case insensitive)

@elaguerta-nr elaguerta-nr force-pushed the elaguerta-nr-patch-1 branch 8 times, most recently from b907490 to bac5e8d Compare May 23, 2024 21:22
@elaguerta-nr elaguerta-nr changed the title fix: update scala workflow to check for java examples in newrelic Fixes: scala for java tests, set fossaAnalyzeResult to N/A May 23, 2024
@elaguerta-nr elaguerta-nr marked this pull request as ready for review May 23, 2024 22:12
@elaguerta-nr elaguerta-nr closed this pull request by merging all changes into main in 294983c May 29, 2024
@elaguerta-nr elaguerta-nr deleted the elaguerta-nr-patch-1 branch May 29, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant