Fast argmax #66
Merged
Fast argmax #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #66 +/- ##
==========================================
+ Coverage 76.70% 77.21% +0.50%
==========================================
Files 19 20 +1
Lines 1391 1422 +31
Branches 270 272 +2
==========================================
+ Hits 1067 1098 +31
Misses 308 308
Partials 16 16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vovaf709
reviewed
Feb 5, 2025
vovaf709
reviewed
Feb 5, 2025
vovaf709
reviewed
Feb 5, 2025
imops/argmax.py
Outdated
| result = argmax(x, axis=-1) | ||
| ``` | ||
| """ | ||
| if array.shape[axis] > 256: |
vovaf709
reviewed
Feb 5, 2025
| name = 'imops' | ||
| on_windows = platform.system() == 'Windows' | ||
| args = ['/openmp' if on_windows else '-fopenmp'] | ||
| args = ['/openmp' if on_windows else '-fopenmp', '-march=native', '-O3'] |
Collaborator
There was a problem hiding this comment.
Did you measure performance diff?
This reverts commit d4cb66c.
vovaf709
approved these changes
Apr 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.