Skip to content

Commit

Permalink
Removes fast_dev_run cause it doesn't work
Browse files Browse the repository at this point in the history
  • Loading branch information
vinamarora8 committed Nov 16, 2024
1 parent e9616b7 commit ab185b6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
3 changes: 1 addition & 2 deletions examples/poyo/configs/base.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,4 @@ gpus: 1

ckpt_path: null # for resuming training, or loading a model during finetuning

fast_dev_run: false
num_sanity_val_steps: 0
num_sanity_val_steps: 0 # only supports 0 (none) and -1 (all) right now
7 changes: 3 additions & 4 deletions examples/poyo/train.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def main(cfg: DictConfig):

# setup loggers
wandb_logger = None
if cfg.wandb.enable and not cfg.fast_dev_run:
if cfg.wandb.enable:
wandb_logger = L.pytorch.loggers.WandbLogger(
save_dir=cfg.log_dir,
entity=cfg.wandb.entity,
Expand Down Expand Up @@ -117,7 +117,6 @@ def main(cfg: DictConfig):
devices=cfg.gpus,
num_nodes=cfg.nodes,
limit_val_batches=None, # Ensure no limit on validation batches
fast_dev_run=cfg.fast_dev_run,
num_sanity_val_steps=cfg.num_sanity_val_steps,
)

Expand Down Expand Up @@ -325,7 +324,7 @@ def val_dataloader(self):
shuffle=False,
batch_size=batch_size,
collate_fn=collate,
num_workers=0,
num_workers=self.cfg.num_workers,
drop_last=False,
)

Expand All @@ -351,7 +350,7 @@ def test_dataloader(self):
shuffle=False,
batch_size=batch_size,
collate_fn=collate,
num_workers=0,
num_workers=self.cfg.num_workers,
)

self.log.info(f"Testing on {len(test_sampler)} samples")
Expand Down

0 comments on commit ab185b6

Please sign in to comment.