Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally log errors #351

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Optionally log errors #351

wants to merge 2 commits into from

Conversation

codermapuche
Copy link

Not all log are errors and it is useful to differentiate when something goes wrong when everything is ok

@neumino
Copy link
Owner

neumino commented Sep 3, 2017

Why isn't that useful? If you add a new server, you want to know whether a pool was created or not

@aleclarson
Copy link
Contributor

@neumino I'm confused, are you saying console.error is necessary to know if the pool was created? Why can't console.log work?

@codermapuche
Copy link
Author

@neumino when use rethinkdbdash in a child proccess, a console.error redirect messages to stderr, not to stdout, this is a ploblem, because the stderr can be used to dispatch an alert, log activity, trace execution and eventually restart the child process, i agree that log new pool connections is useful, but this is not an error, is a desired task.
For this reason not removes the line of the log, only change the target of this message from stderror to stdout.

@neumino
Copy link
Owner

neumino commented Sep 9, 2017

Why can't stderr dispatch an alert? Isn't that an issue with your paging system? You can also just use the log event if you don't want everything to go to stderr.

If you want to change the core/default behavior, please submit a proposal to classify all messages in debug/info/warn/error.
So far no one has proposed a clean API - feel free to reopen #325 if you want

@marshall007
Copy link
Contributor

I had started to spec out an API for this in #334 (comment). That's probably a good starting point if anyone wants to submit a formal proposal.

@aleclarson aleclarson mentioned this pull request Sep 13, 2017
@aleclarson
Copy link
Contributor

Check out #355 as the follow-up to this PR. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants