Fix incompatibility with node 0.10.43 (and probably others) #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rethinkdbdash started with support for 0.11.x only. I think we never supported 0.10.x. On a general note, we somehow don't try very hard to keep compatibility with old versions of node. Node 1.0.0 was released something like 2 years ago, in the node environment, this is a long time to update your node. |
|
close? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR probably needs more review, I basically just hacked this together to get my app running.
The gist is that rethinkdbdash (and the official rethinkdb driver, see rethinkdb/rethinkdb#4816) don't work with tls on node 0.10, this PR fixes that for rethinkdbdash.