Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated list commands #1458

Draft
wants to merge 35 commits into
base: develop
Choose a base branch
from
Draft

Updated list commands #1458

wants to merge 35 commits into from

Conversation

sreichel
Copy link
Collaborator

@sreichel sreichel commented Aug 7, 2024

WIP

@sreichel sreichel marked this pull request as draft August 7, 2024 03:47
@sreichel sreichel changed the title Update list commands (php8-only) Update list commands Aug 7, 2024
@sreichel sreichel changed the title Update list commands Updated list commands Aug 7, 2024
@sreichel
Copy link
Collaborator Author

@cmuench would like to here your opinion on it.

This interface should make it easier to write "list"-commands with different output (text, json, xml).

  • getListHeader ... for the table headers
  • getListData ... to collect the data
  • getSectionTitle ... to have unified output (maybe not needed)

You dont have to care about the output, since everything all done in abstract::execute().

@sreichel
Copy link
Collaborator Author

@cmuench i am blind. I dont see whre this error is comming from. Any ideas?

@sreichel sreichel requested a review from cmuench November 12, 2024 21:14
@sreichel sreichel mentioned this pull request Nov 25, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmuench cmuench Awaiting requested review from cmuench

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sreichel