Updated code CSS wordbreak settings#8
Open
ascopes wants to merge 1 commit intonetty:masterfrom
ascopes:patch-1
Open
Updated code CSS wordbreak settings#8ascopes wants to merge 1 commit intonetty:masterfrom ascopes:patch-1
ascopes wants to merge 1 commit intonetty:masterfrom
ascopes:patch-1
Conversation
Updates <code> tag CSS to enable breaking on word boundaries rather than on any character. This stops things like package names breaking mid-word rather than on the closest appropriate period character, improving readability.
Member
|
IIRC This was intentional because the class names can get quite long, making the paragraph look bad if we don't break it. |
Author
|
@trustin if this is the case, there might be a way to break these up using a JS script similar to http://heap.ch/blog/2016/01/19/camelwrap/ It still doesnt fix the issue for those not using JS, but it will improve the situation. Perhaps implementing the default with a JS shim to alter to this as default may be beneficial? |
Member
|
@ascopes CamelWrap sounds like a good workaround. Could you update this PR to apply CamelWrap so most users see nicely broken identifiers? |
Author
|
Will take a look at the weekend! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates <code> tag CSS to enable breaking on word boundaries rather than
on any character. This stops things like package names breaking mid-word rather
than on the closest appropriate period character, improving readability.
Before (note the
io.netty.examplepart):After: