Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixed packages deps in workspace packages #125

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

nickytonline
Copy link
Contributor

@nickytonline nickytonline commented Jun 29, 2023

Description

Fixes issues with packages from the monorepo as deps of other monorepo packages. This fixes an issue with E2E tests failing for dependency updates, and any PR.

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

N/A

For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This
    ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a
    typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style
    guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@nickytonline nickytonline requested a review from a team as a code owner June 29, 2023 23:36
@nickytonline nickytonline self-assigned this Jun 29, 2023
@github-actions github-actions bot added the type: chore work needed to keep the product and development running smoothly label Jun 29, 2023
@nickytonline nickytonline force-pushed the nickytonline/fix-monorepo-deps branch from d3c6404 to f5cb3e3 Compare June 29, 2023 23:41
@nickytonline nickytonline added the automerge so Kodiak can automatically merge label Jul 4, 2023
@nickytonline nickytonline force-pushed the nickytonline/fix-monorepo-deps branch from d0b7473 to 819477c Compare July 4, 2023 18:41
Copy link
Contributor

@MarcL MarcL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@kodiakhq kodiakhq bot merged commit d88164d into main Jul 5, 2023
@kodiakhq kodiakhq bot deleted the nickytonline/fix-monorepo-deps branch July 5, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge so Kodiak can automatically merge type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants