-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support region
configuration option
#5901
base: main
Are you sure you want to change the base?
Conversation
This pull request adds or modifies JavaScript ( |
|
||
const source = ` | ||
export default async () => new Response("Hello!") | ||
export const config = { region: 'mars-west-1' }` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👽
'eu-central-1', | ||
'eu-north-1', | ||
'eu-south-1', | ||
'eu-west-1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it make sense to include the regions that we don't support in self-serve mode (docs)? The reason we wanted folks to go through Support is to assess whether customers really need these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good catch. I copied this list from the UI but didn't realise two of the regions had a boolean set to false
. I've removed them in 8546f9c.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, there's a third one. Fixed in 30be130.
Quality Gate passedIssues Measures |
@eduardoboucas is this still something you'd like to get shipped? |
Yes, just deprioritised. |
Summary
Adds a
region
property to the in-source function configuration options.Part of https://linear.app/netlify/issue/RUN-1086/add-region-selection-to-in-source-configuration-options.