Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support region configuration option #5901

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

eduardoboucas
Copy link
Member

@eduardoboucas eduardoboucas commented Oct 29, 2024

Summary

Adds a region property to the in-source function configuration options.

Part of https://linear.app/netlify/issue/RUN-1086/add-region-selection-to-in-source-configuration-options.

Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.


const source = `
export default async () => new Response("Hello!")
export const config = { region: 'mars-west-1' }`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👽

'eu-central-1',
'eu-north-1',
'eu-south-1',
'eu-west-1',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it make sense to include the regions that we don't support in self-serve mode (docs)? The reason we wanted folks to go through Support is to assess whether customers really need these

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch. I copied this list from the UI but didn't realise two of the regions had a boolean set to false. I've removed them in 8546f9c.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, there's a third one. Fixed in 30be130.

@eduardoboucas eduardoboucas requested a review from minivan October 29, 2024 11:54
Copy link

@serhalp
Copy link
Contributor

serhalp commented Dec 16, 2024

@eduardoboucas is this still something you'd like to get shipped?

@serhalp serhalp requested a review from a team as a code owner December 16, 2024 14:37
@eduardoboucas
Copy link
Member Author

@eduardoboucas is this still something you'd like to get shipped?

Yes, just deprioritised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants