Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log error message when failing an integration build #5559

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

fix: log error message when failing an integration build #5559

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/build/src/install/missing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
throw new Error(res.stdout)
}
} catch (e) {
throw new Error(`Failed to build integration`)
throw new Error(`Failed to build integration: ${e.message ? e.message : e}`)

Check warning on line 85 in packages/build/src/install/missing.js

View check run for this annotation

Codecov / codecov/patch

packages/build/src/install/missing.js#L85 

Added line #L85 was not covered by tests
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems like e.message will most likely be multi-line output from npm run build- does that work okay with the custom error parsing stuff that @netlify/build has going on?

looking at that error handling I also wonder if a custom ErrorType would be useful here- it looks like stackType: 'message' kind of does what we're attempting to do here, by using the other process' output as the error stack

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cubeghost can you explain what you mean with the custom error parsing stuff? :O I don't think I'm aware of that

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah! I noticed a bunch of code in the src/error directory, particularly src/error/types.ts, and looked at the corresponding documentation. this code not only customizes the error output but also does a bunch of parsing and formatting of stack traces and such.

from what I can see from Uma's error, this error ends up unhandled so it follows the generic exception rules, and it ends up logging two stacks, one for where we're throwing inside of @netlify/build and a less visible one for the actual error in the underlying process.

so I think if we added a new error type specifically for integration build failures, we could customize where the error stack comes from, as well as customizing the error message

}

return undefined
Expand Down
Loading