Skip to content

Conversation

@arthanson
Copy link
Collaborator

@arthanson arthanson commented Dec 10, 2025

Fixes: #20875

Several cases were previously missed:

  • when creating a device from a device template, components are instantiated from the device-template and the denormalized fields are never getting updated.
  • when doing bulk operations the signal was also not getting ran so they weren't updated.

Also checked the API and it looks like the API and this should also affect those. Bulk updates on the API do serializer.save() on each object which will cause the signal handler to run.

Since this is used in both bulk operations and signal handling I used a common routine as I wanted the updates in one place in-case we ever add values or need to modify the logic any.

@arthanson arthanson changed the title DRAFT: #20875 fix updating of denormalized fields (_site, _location, _rack) for component models #20875 fix updating of denormalized fields (_site, _location, _rack) for component models Dec 10, 2025
@arthanson arthanson marked this pull request as ready for review December 10, 2025 18:46
@arthanson arthanson requested review from a team, jeremystretch and jnovinger and removed request for a team December 10, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Interface does not appear under interfaces' site filter

3 participants