Fixes: #15924 - Prevent API payload from allowing tagged_vlans while interface mode is set to tagged-all #17211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…interface mode is set to taged-all
DanSheps
added
the
type: bug
DanSheps
requested review from
jeremystretch
and removed request for
jeremystretch
jeremystretch
removed
the
type: bug
jeremystretch
requested changes
Aug 23, 2024
jeremystretch
requested changes
Aug 26, 2024
…er model in addition to not being able to check incoming vlans under same model.
DanSheps
changed the title
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further action is taken. |
github-actions
bot
added
the
pending closure
DanSheps
removed
the
pending closure
|
Per maintainer meeting, need to refactor logic to try and streamline the checks. |
…into 15924-fix-api-interface-patch-tagged-all-mode
…into 15924-fix-api-interface-patch-tagged-all-mode
DanSheps
added
the
status: blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #15924 and #17249 - Prevent API payload from allowing tagged_vlans while interface mode is set to taged-all and prevent API from allowing untagged_vlan when no 802.1q mode is set.