Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support e2e tests against multiple NetBox versions #176

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

henrybear327
Copy link
Collaborator

@henrybear327 henrybear327 commented Dec 16, 2024

(Reopen #167. Due to PR base branch setting errors, I can't reopen the original PR...)

Since we are introducing the e2e test and running against real NetBox instances, it makes sense to test against different versions of NetBox, so we can flag issues early on.

CI will now run all e2e tests against the supported versions.

The supported NetBox versions are (the latest patch version for the major.minor release):

  • 3.7.8
  • 4.0.11
  • 4.1.8

Instead of create-kind, we now have create-kind-3.7.8, create-kind-4.0.11, and create-kind-4.1.8. The same goes for make test-e2e.

The patching mechanism is used to apply database schema fixes and demo data version changes. When we introduce support for new versions, usually only the database schema would need to be changed.

Blocked by #175 (#177)

@henrybear327 henrybear327 self-assigned this Dec 16, 2024
@henrybear327 henrybear327 marked this pull request as draft December 16, 2024 12:10
@henrybear327 henrybear327 force-pushed the e2e/add_multi_version_support branch 7 times, most recently from 23adae8 to 3e98547 Compare December 18, 2024 10:41
@henrybear327 henrybear327 marked this pull request as ready for review December 18, 2024 10:43
@henrybear327 henrybear327 force-pushed the e2e/add_multi_version_support branch from 3e98547 to 845ad6c Compare December 18, 2024 10:56
@henrybear327
Copy link
Collaborator Author

To test this locally, execute make test-e2e-4.1.8 (or other supported versions)

@henrybear327 henrybear327 force-pushed the e2e/add_multi_version_support branch from 845ad6c to c52c6c3 Compare December 19, 2024 12:49
kind/local-env.sh Outdated Show resolved Hide resolved
@henrybear327 henrybear327 force-pushed the e2e/add_multi_version_support branch from e58e9ab to b96d814 Compare December 20, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants