Fix LDAP group mirroring #465
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoColomb
requested changes
Dec 26, 2024
There was a problem hiding this comment.
Thanks for submitting this pull request, @Paktosan.
Good catch! Let's improve the schema to match all possibilities as per documentation: https://django-auth-ldap.readthedocs.io/en/latest/reference.html#auth-ldap-mirror-groups
Thus, see my inline suggestions.
The chart version also needs to be bumped.
| @@ -1060,7 +1060,7 @@ | |||
| "type": "boolean" | |||
There was a problem hiding this comment.
Suggested change
| "type": "boolean" | |
| "type": ["boolean", "string", "array"] |
| @@ -1060,7 +1060,7 @@ | |||
| "type": "boolean" | |||
| }, | |||
| "mirrorGroupsExcept": { | |||
| "type": "string" | |||
| "type": "array" | |||
There was a problem hiding this comment.
Suggested change
| "type": "array" | |
| "type": ["null", "string", "array"] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an error likely introduced in 04c18cd which prevents configuring a working LDAP setup with this chart.
Currently the chart forces
mirrorGroupsExceptto be a string which results in Netbox throwing the following error when trying to log in:With the proposed change, the correct type is set in the schema and a sensible default in the
values.yamlis added.