Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scriptsPersistence PVC #232

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Add scriptsPersistence PVC #232

merged 2 commits into from
Jun 4, 2024

Conversation

braninl
Copy link
Contributor

@braninl braninl commented Jun 4, 2024 •
edited
Loading

It looks like creating the PersistentVolumeClaim itself was missed in PR 224, so this adds onto that.

RangerRick
RangerRick previously approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@RangerRick RangerRick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! LGTM

@RangerRick
Copy link
Contributor

If you can bump the version in charts/netbox/Chart.yaml to 5.0.0-beta.22 it should pass checks and I can merge it. Thanks for the submission!

@braninl
Copy link
Contributor Author

braninl commented Jun 4, 2024

Bumped. Thanks!

@RangerRick RangerRick merged commit fca231f into netbox-community:develop Jun 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RangerRick RangerRick RangerRick approved these changes

@LeoColomb LeoColomb LeoColomb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@braninl @RangerRick @LeoColomb