Quick fix for #165: Make some *_count fields non-required #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosheskaz
reviewed
Jul 26, 2024
| @@ -130139,7 +130116,6 @@ components: | |||
| - display | |||
| - id | |||
| - name | |||
| - prefix_count | |||
| - slug | |||
| - url | |||
| - vlan_count | |||
There was a problem hiding this comment.
vlan_count is also affected / in-scope
|
Would be very awesome to see this land. We're getting hit with |
nutgood
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
We've reviewed this and are using it internally @ sherweb/go-netbox. We can confirm this works as expected and got rid of all errors. We've reviewed all changes in this PR and there's no unexpected code.
We'd love to get back to the upstream (this repo) and would also love for this to land.
clinta
added a commit
to clinta/go-netbox
that referenced
this pull request
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.