Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all Dell PowerConnect 5500 switches #2629

Merged
merged 5 commits into from
Jan 13, 2025

Conversation

BCurrell
Copy link
Contributor

Add the full set of Dell PowerConnect 5500 series switches:

  • Add 5524
  • Add 5524P
  • Add 5548
  • Update 5548P

Also run pre-commit to make sure formatting is all correct.

@BCurrell BCurrell marked this pull request as ready for review January 12, 2025 23:51
@BCurrell BCurrell changed the title Dell 55xx Add all Dell PowerConnect 5500 switches Jan 12, 2025
@BCurrell
Copy link
Contributor Author

I'm having some issues with pre-commit. Successful manual run but its blocking my commits for some reason. Going to ignore it for now and force the push, hopefully the Github actions handle the checks properly:

(venv) bcurrell@framework:~/Documents/netbox-community-devicetype-library$ git status
On branch dell-55xx
Changes to be committed:
  (use "git restore --staged <file>..." to unstage)
        modified:   device-types/Dell/PowerConnect-5524.yaml
        modified:   device-types/Dell/PowerConnect-5524p.yaml
        modified:   device-types/Dell/PowerConnect-5548.yaml
        modified:   device-types/Dell/PowerConnect-5548p.yaml

(venv) bcurrell@framework:~/Documents/netbox-community-devicetype-library$ pre-commit run
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
Check YAML files.........................................................Passed
Format YAML files........................................................Passed
Lint YAML files..........................................................Passed
markdownlint-cli2....................................(no files to check)Skipped
Run PyTest Case Checks...................................................Passed
(venv) bcurrell@framework:~/Documents/netbox-community-devicetype-library$ git commit -am "Add airflow"
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
Check YAML files.........................................................Passed
Format YAML files........................................................Passed
Lint YAML files..........................................................Passed
markdownlint-cli2....................................(no files to check)Skipped
Run PyTest Case Checks...................................................Failed
- hook id: pytest
- files were modified by this hook

============================= test session starts ==============================
platform linux -- Python 3.12.3, pytest-8.3.4, pluggy-1.5.0 -- /home/bcurrell/Documents/netbox-community-devicetype-library/venv/bin/python3
cachedir: .pytest_cache
rootdir: /home/bcurrell/Documents/netbox-community-devicetype-library
collected 9 items                                                              

tests/definitions_test.py::test_environment SKIPPED (No changes to d...) [ 11%]
tests/definitions_test.py::test_definitions[device-types/Dell/PowerConnect-5524.yaml-schema0-A] PASSED [ 22%]
tests/definitions_test.py::test_definitions[device-types/Dell/PowerConnect-5524p.yaml-schema1-A] PASSED [ 33%]
tests/definitions_test.py::test_definitions[device-types/Dell/PowerConnect-5548.yaml-schema2-A] PASSED [ 44%]
tests/definitions_test.py::test_definitions[device-types/Dell/PowerConnect-5548p.yaml-schema3-M] PASSED [ 55%]
tests/definitions_test.py::test_definitions[device-types/Dell/PowerConnect-5524.yaml-schema4-M] PASSED [ 66%]
tests/definitions_test.py::test_definitions[device-types/Dell/PowerConnect-5524p.yaml-schema5-M] PASSED [ 77%]
tests/definitions_test.py::test_definitions[device-types/Dell/PowerConnect-5548.yaml-schema6-M] PASSED [ 88%]
tests/definitions_test.py::test_definitions[device-types/Dell/PowerConnect-5548p.yaml-schema7-M] PASSED [100%]

======================== 8 passed, 1 skipped in 28.39s =========================

(venv) bcurrell@framework:~/Documents/netbox-community-devicetype-library$ pytest --tb=short -v
============================================================================================================= test session starts =============================================================================================================
platform linux -- Python 3.12.3, pytest-8.3.4, pluggy-1.5.0 -- /home/bcurrell/Documents/netbox-community-devicetype-library/venv/bin/python3
cachedir: .pytest_cache
rootdir: /home/bcurrell/Documents/netbox-community-devicetype-library
collected 9 items                                                                                                                                                                                                                             

tests/definitions_test.py::test_environment SKIPPED (No changes to definition files found.)                                                                                                                                             [ 11%]
tests/definitions_test.py::test_definitions[device-types/Dell/PowerConnect-5524.yaml-schema0-A] PASSED                                                                                                                                  [ 22%]
tests/definitions_test.py::test_definitions[device-types/Dell/PowerConnect-5524p.yaml-schema1-A] PASSED                                                                                                                                 [ 33%]
tests/definitions_test.py::test_definitions[device-types/Dell/PowerConnect-5548.yaml-schema2-A] PASSED                                                                                                                                  [ 44%]
tests/definitions_test.py::test_definitions[device-types/Dell/PowerConnect-5548p.yaml-schema3-M] PASSED                                                                                                                                 [ 55%]
tests/definitions_test.py::test_definitions[device-types/Dell/PowerConnect-5524.yaml-schema4-M] PASSED                                                                                                                                  [ 66%]
tests/definitions_test.py::test_definitions[device-types/Dell/PowerConnect-5524p.yaml-schema5-M] PASSED                                                                                                                                 [ 77%]
tests/definitions_test.py::test_definitions[device-types/Dell/PowerConnect-5548.yaml-schema6-M] PASSED                                                                                                                                  [ 88%]
tests/definitions_test.py::test_definitions[device-types/Dell/PowerConnect-5548p.yaml-schema7-M] PASSED                                                                                                                                 [100%]

======================================================================================================== 8 passed, 1 skipped in 26.90s ========================================================================================================
(venv) bcurrell@framework:~/Documents/netbox-community-devicetype-library$ 

@harryajc harryajc merged commit 735b10a into netbox-community:master Jan 13, 2025
3 checks passed
@BCurrell BCurrell deleted the dell-55xx branch January 13, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants