Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create V1910-8G-PoE+(180W).yaml #2557

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Create V1910-8G-PoE+(180W).yaml #2557

wants to merge 5 commits into from

Conversation

alexpitcher
Copy link

Added 1910-8G-PoE+ 180W switch device type.

danner26
danner26 requested changes Dec 26, 2024
View reviewed changes
Copy link
Member

@danner26 danner26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the comments mentioned, along with resolving the failed test case. Thank you

device-types/HPE/v1910-8g-poep-180w
slug: hpe-v1910-8g-poep-180w
part_number: JG350A
u_height: 1
is_full_depth: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thank you for your contribution! In an attempt to have the most accurate and complete data we can, I have a few additional data points we would like you to add if possible.

  1. Please add the airflow data point if you have it or can find it. Often these are listed in the datasheet, but sometimes they are not
  2. Please add the weight and associated weight_unit data point if you have it or can find it. Often these are listed in the datasheet, but sometimes they are not

If you have any questions, please let us know :)

@danner26 danner26 added the status: revisions needed This issue requires additional information to be actionable label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danner26 danner26 danner26 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
status: revisions needed This issue requires additional information to be actionable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexpitcher @danner26