Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add front images and new LC/SC panes using a defined rear splice #2124

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Add front images and new LC/SC panes using a defined rear splice #2124

wants to merge 12 commits into from

Conversation

netravnen
Copy link
Contributor

@netravnen netravnen commented Apr 30, 2024 •
edited
Loading

  • Add some missing front images,
  • set is_powered to false,
  • rename SC-12-{port-duplex,double-port}-fiber-patch-panel-rear-splice,
  • add additional panels configured to use rear splices in configurations of 12/24/48 fibres to a cassette,
  • streamline port naming to follow "schema" Port X, Splice X

@netravnen netravnen force-pushed the generic-sc-24-front-images branch from 41097f9 to f024960 Compare May 1, 2024 12:37
danner26
danner26 reviewed May 20, 2024
View reviewed changes
device-types/Generic/SC-12-port-duplex-fiber-patch-panel-rear-splice.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this file deleted?

@danner26 danner26 added the status: gathering feedback Further discussion is needed to determine this issue's scope and/or implementation label May 20, 2024
@danner26 danner26 marked this pull request as draft May 20, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danner26 danner26 danner26 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
status: gathering feedback Further discussion is needed to determine this issue's scope and/or implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@netravnen @danner26