Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: really disable ssl warnings in console #121

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ndom91
Copy link
Contributor

@ndom91 ndom91 commented Jan 2, 2024

  • Enable hiding the urllib3 warnings if ignore_ssl env var is enabled. Previously, when that env var option is enabled the import would work, but the output would be flooded with urllib3 warnings making the normal output almost unreadable.
  • Remove "tested with.." note from README, just leads to confusion and is difficult to keep up-to-date. Just ran this with 3.7.0 and it successfully updated some device-types, imported new device-types, and even added images to some existing device-types. So I'd say its fine for the latest version of Netbox as well.

@daryll-swer
Copy link

@ndom91 Can the SSL warning issue be “resolved” instead of just suppressing the warnings? Perhaps with latest version of urllib3?

This seems to suggest a “bug free” version (presumably latest version 2.1.0), resolves the actual issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants