-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): env variable to control slow threshold of token factory #13799
base: master
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build ecf984e0-9894-4582-afce-61a77c6239daDetails
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks simple and effective, thank you!
Hi @H4ad , thank you so much for making this PR! Indeed, this warning is driving us crazy today :) Is anything blocking you from merging it and having it in the next patch version of NestJS? Would be great to have it |
Sorry for nagging here, but can someone from the NestJS team approve/merge this PR by any chance? |
bump |
/cc @kamilmysliwiec Can we merge this to release in the v11? |
We probably won't need that in v11 as the |
Do you think is worthy to include only in v10? Otherwise, I will close this PR |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Today, there's no way to change the threshold we added for slow serialization.
Refs: #12738 (comment)
What is the new behavior?
Now, we can control the amount of time in MS using
NEST_TOKEN_FACTORY_SLOW_THRESHOLD_MS
Does this PR introduce a breaking change?
Other information