Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(microservices): change isNotKafkaMessage validation condition #13375

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jochongs
Copy link

@jochongs jochongs commented Mar 30, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

If either key or value is included in the object, it will be treated as a Kafka message.

Issue Number: #12886

What is the new behavior?

Objects containing both key and value attributes will be treated as Kafka messages.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

If concerns about breaking changes arise, it might be necessary to utilize an options object.

@coveralls
Copy link

Pull Request Test Coverage Report for Build e841d23b-c7bc-498f-9e0c-cfad07a98ab4

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.123%

Totals Coverage Status
Change from base Build eacd3e56-4bed-4f5e-9bab-412a10335aab: 0.0%
Covered Lines: 6736
Relevant Lines: 7312

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants