forked from typestack/class-validator
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement AllowIf decorator #86
Open
chambber
wants to merge
140
commits into
nestjs:master
Choose a base branch
from
chambber:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+2,845
−12,215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore(deps): pin dependencies
chore(deps): update dependency @types/node to v14.17.32
…esolve-11.x chore(deps): update dependency @rollup/plugin-node-resolve to v11.2.1
chore(deps): update dependency lint-staged to v10.5.4
chore(deps): update dependency husky to v4.3.8
chore(deps): update dependency eslint to v7.32.0
chore(deps): update dependency rollup to v2.58.3
…24.x chore(deps): update dependency eslint-plugin-jest to v24.7.0
chore(deps): update dependency ts-jest to v26.5.6
chore(deps): update dependency rollup to v2.67.2
chore(deps): update dependency ts-node to v10.5.0
chore(deps): update dependency lint-staged to v12.3.4
…25.x chore(deps): update dependency eslint-plugin-jest to v25.7.0
chore(deps): update jest monorepo
…onorepo chore(deps): update typescript-eslint monorepo to v5.11.0
Hey @kamilmysliwiec, it's my first contribution to an open-source project, if you need to change something in PR, just say so! |
@chambber @kamilmysliwiec why this feature is not merged? BTW we have this one too: https://stackoverflow.com/a/70128576/8784518 |
kamilmysliwiec
force-pushed
the
master
branch
2 times, most recently
from
June 20, 2023 07:03
7b454dd
to
5f0d424
Compare
I would like to use this feature. Is there any chance it will end up in nestJs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
There is currently no way to define whether a property is conditionally whitelisted, for example:
Issue Number: typestack#1489
What is the new behavior?
Does this PR introduce a breaking change?