feat: support fiber multiple hops payment in cross chain transaction #615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
doitian
force-pushed
the
contrun/support-fiber-multiple-hops-payment-in-cross-chain-transaction
branch
from
5acd6e8 to
596b448
Compare
This comment was marked as outdated.
This comment was marked as outdated.
doitian
force-pushed
the
contrun/support-fiber-multiple-hops-payment-in-cross-chain-transaction
branch
from
596b448 to
ba6585c
Compare
doitian
force-pushed
the
contrun/support-fiber-multiple-hops-payment-in-cross-chain-transaction
branch
3 times, most recently
from
c4c2296 to
66737cd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #615 +/- ##
========================================
Coverage 0.00% 0.00%
========================================
Files 55 57 +2
Lines 34753 35093 +340
========================================
- Misses 34753 35093 +340
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
doitian
force-pushed
the
contrun/support-fiber-multiple-hops-payment-in-cross-chain-transaction
branch
5 times, most recently
from
19523f1 to
98f93b5
Compare
chenyukang
reviewed
Jun 14, 2025
doitian
added a commit
to doitian/fiber
that referenced
this pull request
Jun 15, 2025
Add StoreWithPubSub to emit store update events. It uses ractor OutputPort for pub-sub. This is a rework of StoreWithHooks in nervosnetwork#511 - Use decorator pattern to add additional features on Store - Minimize the interface change that original codes relying on Store traits dot not need to change. - Avoid using an Actor to fetch extra data asynchronously. This resolves the issue mentioned in nervosnetwork#615 (comment) . The channel actor cleans preimage on success payment automatically. Thus we may fail to get the preimage when settling the cch payment in the BTC end.
doitian
force-pushed
the
contrun/support-fiber-multiple-hops-payment-in-cross-chain-transaction
branch
from
ca873f2 to
ed4e533
Compare
doitian
added a commit
to doitian/fiber
that referenced
this pull request
Jun 15, 2025
Add StoreWithPubSub to emit store update events. It uses ractor OutputPort for pub-sub. This is a rework of StoreWithHooks in nervosnetwork#511 - Use decorator pattern to add additional features on Store - Minimize the interface change that original codes relying on Store traits dot not need to change. - Avoid using an Actor to fetch extra data asynchronously. This resolves the issue mentioned in nervosnetwork#615 (comment) . The channel actor cleans preimage on success payment automatically. Thus we may fail to get the preimage when settling the cch payment in the BTC end.
doitian
added a commit
to doitian/fiber
that referenced
this pull request
Jun 15, 2025
Add StoreWithPubSub to emit store update events. It uses ractor OutputPort for pub-sub. This is a rework of StoreWithHooks in nervosnetwork#511 - Use decorator pattern to add additional features on Store - Minimize the interface change that original codes relying on Store traits dot not need to change. - Avoid using an Actor to fetch extra data asynchronously. This resolves the issue mentioned in nervosnetwork#615 (comment) . The channel actor cleans preimage on success payment automatically. Thus we may fail to get the preimage when settling the cch payment in the BTC end.
doitian
force-pushed
the
contrun/support-fiber-multiple-hops-payment-in-cross-chain-transaction
branch
from
ed4e533 to
569fbaf
Compare
doitian
added a commit
to doitian/fiber
that referenced
this pull request
Jun 15, 2025
Add StoreWithPubSub to emit store update events. It uses ractor OutputPort for pub-sub. This is a rework of StoreWithHooks in nervosnetwork#511 - Use decorator pattern to add additional features on Store - Minimize the interface change that original codes relying on Store traits dot not need to change. - Avoid using an Actor to fetch extra data asynchronously. This resolves the issue mentioned in nervosnetwork#615 (comment) . The channel actor cleans preimage on success payment automatically. Thus we may fail to get the preimage when settling the cch payment in the BTC end.
doitian
force-pushed
the
contrun/support-fiber-multiple-hops-payment-in-cross-chain-transaction
branch
from
569fbaf to
05d7f07
Compare
doitian
added a commit
to doitian/fiber
that referenced
this pull request
Jun 15, 2025
Add StoreWithPubSub to emit store update events. It uses ractor OutputPort for pub-sub. This is a rework of StoreWithHooks in nervosnetwork#511 - Use decorator pattern to add additional features on Store - Minimize the interface change that original codes relying on Store traits dot not need to change. - Avoid using an Actor to fetch extra data asynchronously. This resolves the issue mentioned in nervosnetwork#615 (comment) . The channel actor cleans preimage on success payment automatically. Thus we may fail to get the preimage when settling the cch payment in the BTC end.
doitian
force-pushed
the
contrun/support-fiber-multiple-hops-payment-in-cross-chain-transaction
branch
from
05d7f07 to
4b7a93b
Compare
doitian
force-pushed
the
contrun/support-fiber-multiple-hops-payment-in-cross-chain-transaction
branch
5 times, most recently
from
40703dc to
cc69a53
Compare
doitian
added a commit
to doitian/fiber
that referenced
this pull request
Jun 30, 2025
Add StoreWithPubSub to emit store update events. It uses ractor OutputPort for pub-sub. This is a rework of StoreWithHooks in nervosnetwork#511 - Use decorator pattern to add additional features on Store - Minimize the interface change that original codes relying on Store traits dot not need to change. - Avoid using an Actor to fetch extra data asynchronously. This resolves the issue mentioned in nervosnetwork#615 (comment) . The channel actor cleans preimage on success payment automatically. Thus we may fail to get the preimage when settling the cch payment in the BTC end.
doitian
force-pushed
the
contrun/support-fiber-multiple-hops-payment-in-cross-chain-transaction
branch
from
cc69a53 to
5e12c6f
Compare
doitian
added a commit
to doitian/fiber
that referenced
this pull request
Aug 11, 2025
Add StoreWithPubSub to emit store update events. It uses ractor OutputPort for pub-sub. This is a rework of StoreWithHooks in nervosnetwork#511 - Use decorator pattern to add additional features on Store - Minimize the interface change that original codes relying on Store traits dot not need to change. - Avoid using an Actor to fetch extra data asynchronously. This resolves the issue mentioned in nervosnetwork#615 (comment) . The channel actor cleans preimage on success payment automatically. Thus we may fail to get the preimage when settling the cch payment in the BTC end.
doitian
added a commit
to doitian/fiber
that referenced
this pull request
Aug 11, 2025
Add StoreWithPubSub to emit store update events. It uses ractor OutputPort for pub-sub. This is a rework of StoreWithHooks in nervosnetwork#511 - Use decorator pattern to add additional features on Store - Minimize the interface change that original codes relying on Store traits dot not need to change. - Avoid using an Actor to fetch extra data asynchronously. This resolves the issue mentioned in nervosnetwork#615 (comment) . The channel actor cleans preimage on success payment automatically. Thus we may fail to get the preimage when settling the cch payment in the BTC end.
doitian
added a commit
to doitian/fiber
that referenced
this pull request
Aug 11, 2025
Add StoreWithPubSub to emit store update events. It uses ractor OutputPort for pub-sub. This is a rework of StoreWithHooks in nervosnetwork#511 - Use decorator pattern to add additional features on Store - Minimize the interface change that original codes relying on Store traits dot not need to change. - Avoid using an Actor to fetch extra data asynchronously. This resolves the issue mentioned in nervosnetwork#615 (comment) . The channel actor cleans preimage on success payment automatically. Thus we may fail to get the preimage when settling the cch payment in the BTC end.
doitian
added a commit
to doitian/fiber
that referenced
this pull request
Aug 12, 2025
Add StoreWithPubSub to emit store update events. It uses ractor OutputPort for pub-sub. This is a rework of StoreWithHooks in nervosnetwork#511 - Use decorator pattern to add additional features on Store - Minimize the interface change that original codes relying on Store traits dot not need to change. - Avoid using an Actor to fetch extra data asynchronously. This resolves the issue mentioned in nervosnetwork#615 (comment) . The channel actor cleans preimage on success payment automatically. Thus we may fail to get the preimage when settling the cch payment in the BTC end.
doitian
added a commit
to doitian/fiber
that referenced
this pull request
Aug 12, 2025
Add StoreWithPubSub to emit store update events. It uses ractor OutputPort for pub-sub. This is a rework of StoreWithHooks in nervosnetwork#511 - Use decorator pattern to add additional features on Store - Minimize the interface change that original codes relying on Store traits dot not need to change. - Avoid using an Actor to fetch extra data asynchronously. This resolves the issue mentioned in nervosnetwork#615 (comment) . The channel actor cleans preimage on success payment automatically. Thus we may fail to get the preimage when settling the cch payment in the BTC end.
doitian
force-pushed
the
contrun/support-fiber-multiple-hops-payment-in-cross-chain-transaction
branch
from
5e12c6f to
4cae544
Compare
doitian
added a commit
to doitian/fiber
that referenced
this pull request
Aug 13, 2025
Add StoreWithPubSub to emit store update events. It uses ractor OutputPort for pub-sub. This is a rework of StoreWithHooks in nervosnetwork#511 - Use decorator pattern to add additional features on Store - Minimize the interface change that original codes relying on Store traits dot not need to change. - Avoid using an Actor to fetch extra data asynchronously. This resolves the issue mentioned in nervosnetwork#615 (comment) . The channel actor cleans preimage on success payment automatically. Thus we may fail to get the preimage when settling the cch payment in the BTC end.
doitian
force-pushed
the
contrun/support-fiber-multiple-hops-payment-in-cross-chain-transaction
branch
2 times, most recently
from
2e456fd to
838e0f4
Compare
doitian
added a commit
to doitian/fiber
that referenced
this pull request
Aug 15, 2025
Add StoreWithPubSub to emit store update events. It uses ractor OutputPort for pub-sub. This is a rework of StoreWithHooks in nervosnetwork#511 - Use decorator pattern to add additional features on Store - Minimize the interface change that original codes relying on Store traits dot not need to change. - Avoid using an Actor to fetch extra data asynchronously. This resolves the issue mentioned in nervosnetwork#615 (comment) . The channel actor cleans preimage on success payment automatically. Thus we may fail to get the preimage when settling the cch payment in the BTC end.
doitian
force-pushed
the
contrun/support-fiber-multiple-hops-payment-in-cross-chain-transaction
branch
from
838e0f4 to
87ce55b
Compare
|
Actions required: refactor the code to make cch a non-wasm feature. Current code base has to put |
doitian
force-pushed
the
contrun/support-fiber-multiple-hops-payment-in-cross-chain-transaction
branch
2 times, most recently
from
d95c490 to
6674b19
Compare
Add StoreWithPubSub to emit store update events. It uses ractor OutputPort for pub-sub. This is a rework of StoreWithHooks in nervosnetwork#511 - Use decorator pattern to add additional features on Store - Minimize the interface change that original codes relying on Store traits dot not need to change. - Avoid using an Actor to fetch extra data asynchronously. This resolves the issue mentioned in nervosnetwork#615 (comment) . The channel actor cleans preimage on success payment automatically. Thus we may fail to get the preimage when settling the cch payment in the BTC end.
doitian
force-pushed
the
contrun/support-fiber-multiple-hops-payment-in-cross-chain-transaction
branch
from
6674b19 to
7cb43f9
Compare
doitian
force-pushed
the
contrun/support-fiber-multiple-hops-payment-in-cross-chain-transaction
branch
from
7cb43f9 to
af20ea6
Compare
doitian
force-pushed
the
contrun/support-fiber-multiple-hops-payment-in-cross-chain-transaction
branch
from
3c3a1b3 to
5741722
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #511
new_invoiceRPC to auto generate preimage when neither preimage nor hash is set. 57f6e09Co-Authored-By: @contrun